Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dws: disable fluxion scheduling of rabbits #114

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jameshcorbett
Copy link
Member

Problem: fluxion scheduling of rabbits is working but requires some configuration changes on the machines it would be used on (LC's El Cap EA machines).

Disable fluxion scheduling temporarily until the config changes can be worked out.

This commit should be reverted before the next major release.

Problem: fluxion scheduling of rabbits is working but requires some
configuration changes on the machines it would be used on (LC's
El Cap EA machines).

Disable fluxion scheduling temporarily until the config changes can
be worked out.
@jameshcorbett jameshcorbett requested a review from grondo November 30, 2023 00:55
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't really understand the change here (unsurprising), but everything LGTM.

One alternative might be to somehow add a configuration parameter and default it to off so you don't have to revert a commit later (just update configuration when the support is ready).

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to approve.

@jameshcorbett
Copy link
Member Author

Ok, I don't really understand the change here (unsurprising), but everything LGTM.

One alternative might be to somehow add a configuration parameter and default it to off so you don't have to revert a commit later (just update configuration when the support is ready).

Do you mean have something like a command-line argument, and then add a check like if ARGUMENT: do thing? That makes sense but I would want to remove that check eventually so I don't really think it would save any git churn.

@grondo
Copy link
Contributor

grondo commented Nov 30, 2023

Sounds reasonable!

@mergify mergify bot merged commit cfbdd5a into flux-framework:master Nov 30, 2023
8 checks passed
@jameshcorbett jameshcorbett deleted the temp-disable-fluxion branch November 30, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants