Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faq: update openmpi faq to reference pmix #274

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

wihobbs
Copy link
Member

@wihobbs wihobbs commented Aug 15, 2024

I put and/or because it sounds like you need one on Azure (or possibly both) and the other on LC resources. Could differ at other centers too depending on if pmix is the default.

@garlick
Copy link
Member

garlick commented Aug 16, 2024

Oh good catch. In fact, the openmpi@5option is no longer supported (hasn't been since 2021!)

You might want to tack on:

In fact -o pmi=pmix also works for earlier versions of openmpi, and appears to avoid a UCX related deadlock in openmpi 4.1.2 (see flux-framework/flux-core#5460)

@wihobbs
Copy link
Member Author

wihobbs commented Aug 16, 2024

Thanks @garlick! Added your changes verbatim, dropped -ompi=openmpi@5, rebased and pushed.

@garlick
Copy link
Member

garlick commented Aug 16, 2024

Check the CI preview - looks like the issue link isn't rendering properly. Also, maybe it would read better if the sentence I suggested is in the same paragraph as the other one?

faqs.rst Outdated

In fact, ``-o pmi=pmix`` also works for earlier versions of OpenMPI, and
appears to avoid a UCX related deadlock in OpenMPI 4.1.2 (see
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link needs to end with an underscore:

Suggested change
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`)
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`_)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was it. Forgot to push 🤦

@wihobbs
Copy link
Member Author

wihobbs commented Aug 21, 2024

I can't get this to build locally because of (I think) lab network weirdness, so waiting for the RTD to render so I can check that it all looks right.

Problem: our OpenMPI FAQ does not explicitly say users
should be running with the pmix shell attribute.

Add that.
@wihobbs
Copy link
Member Author

wihobbs commented Aug 21, 2024

@garlick I also dropped "upcoming" when referencing OpenMPI 5, since it was released July 22, 2024.

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wihobbs wihobbs added the merge-when-passing mark PR for auto-merging by mergify.io bot label Aug 21, 2024
@mergify mergify bot merged commit 2dea7bf into flux-framework:master Aug 21, 2024
7 checks passed
@wihobbs wihobbs deleted the openmpi-faq branch August 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants