-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faq: update openmpi faq to reference pmix #274
Conversation
Oh good catch. In fact, the You might want to tack on:
|
Thanks @garlick! Added your changes verbatim, dropped |
Check the CI preview - looks like the issue link isn't rendering properly. Also, maybe it would read better if the sentence I suggested is in the same paragraph as the other one? |
faqs.rst
Outdated
|
||
In fact, ``-o pmi=pmix`` also works for earlier versions of OpenMPI, and | ||
appears to avoid a UCX related deadlock in OpenMPI 4.1.2 (see | ||
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the link needs to end with an underscore:
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`) | |
`flux-framework/flux-core#5460 <https://github.com/flux-framework/flux-core/issues/5460>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that was it. Forgot to push 🤦
I can't get this to build locally because of (I think) lab network weirdness, so waiting for the RTD to render so I can check that it all looks right. |
Problem: our OpenMPI FAQ does not explicitly say users should be running with the pmix shell attribute. Add that.
@garlick I also dropped "upcoming" when referencing OpenMPI 5, since it was released July 22, 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I put and/or because it sounds like you need one on Azure (or possibly both) and the other on LC resources. Could differ at other centers too depending on if pmix is the default.