Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit: add docs on preset #DW strings #291

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jameshcorbett
Copy link
Member

Problem: flux-coral2 supports preset DW strings, but they aren't described in the rabbit docs.

Add documentation.

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice add :-)

will display a mapping of the presets that have been configured on the
current system. The keys of the mapping are the strings that you can
pass to ``-S dw=...``, the values of the mapping are the actual DW directives
they presets correspond to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I am misunderstanding; their instead of they here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks! I think I wanted the actually (although their would also work). Fixed and force-pushed. Setting MWP

Problem: flux-coral2 supports preset DW strings, but they aren't
described in the rabbit docs.

Add documentation.
@jameshcorbett jameshcorbett added the merge-when-passing mark PR for auto-merging by mergify.io bot label Dec 5, 2024
@mergify mergify bot merged commit ade1abc into flux-framework:master Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants