Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fms): FMC reset through overhead reset panel #9685

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 29, 2024

Summary of Changes

Enable resetting FMCs through overhead reset panel. Lays ground work for future system resets.

  • Add XML templates for overhead reset panel buttons for FMCs
  • Add logic for FMS re-initialization when pulling C/Bs or rather reset P/Bs
  • Display "FMS PAGE NOT AVAIL" and "MAP NOT AVAIL" when appropriate

Screenshots (if necessary)

image

Disclaimer: Even when the ND shows "MAP NOT AVAIL", the route is still shown. Either it's the new BACKUP TRAJ feature, or I simply didn't refactor the ND yet (out of scope for this PR, needs larger flight guidance/AFS CP adaptions likely):
image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Set up FMS using SOP
  2. Pull FMC-A, FMC-B and FMC-C reset push buttons (on overhead panel), FMS should be reset as soon as all three buttons are pulled out - but not earlier
  3. Try resetting or failing (via EFB) different combinations of FMCs, and play around with the FMS switching knob. The MFD system selector ("FMS x") should behave as expected, i.e. display FMS 1, FMS 2, FMS 1-C or FMS 2-C depending on the configuration.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Dec 29, 2024
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the XML.

@flogross89 flogross89 requested a review from tracernz January 3, 2025 01:13
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 3, 2025
@BravoMike99
Copy link
Contributor

BravoMike99 commented Jan 5, 2025

Quality Assurance Tester Report

Discord Username : bruno_pt99
Object of testing : #9685
Aircraft : A380X
Tier of Testing : 1
Date : 05/01/2025

Testing Process:
Setup FMS:

  • Pulled reset buttons of each FMC individually. FMC resets after all 3 have been pulled ✔️

  • Pushed the reset buttons to bring the FMCs back to life and route flickering happened on ND & on pfd target speeds, in addition, the MFD pages still show data and stop doing so after a page change/refresh ❌

Testing Results:
Not Passed

Negatives:
Weird stuff happens on PFD & ND after FMS is reset. As visible, the route appears flickering despite no route being present on MFD, target speeds on PFD flicker etc (check media).
I would also go against resetting the FMS data immediately after power is lost. Chances are there's some kind of internal battery which stores the data for some time like the A320.

Media:
https://github.com/user-attachments/assets/5c2181e1-5523-479e-8033-c2bb6c6c970e

@flogross89
Copy link
Contributor Author

Quality Assurance Tester Report

Discord Username : bruno_pt99 Object of testing : #9685 Aircraft : A380X Tier of Testing : 1 Date : 05/01/2025

Testing Process: Setup FMS:

  • Pulled reset buttons of each FMC individually. FMC resets after all 3 have been pulled ✔️
  • Pushed the reset buttons to bring the FMCs back to life and route flickering happened on ND & on pfd target speeds, in addition, the MFD pages still show data and stop doing so after a page change/refresh ❌

Testing Results: Not Passed

Negatives: Weird stuff happens on PFD & ND after FMS is reset. As visible, the route appears flickering despite no route being present on MFD, target speeds on PFD flicker etc (check media). I would also go against resetting the FMS data immediately after power is lost. Chances are there's some kind of internal battery which stores the data for some time like the A320.

Media: https://github.com/user-attachments/assets/5c2181e1-5523-479e-8033-c2bb6c6c970e

Thanks! Three changes with the latest commit:

  • Don't destroy and re-init FMC, but rather reset
  • Only reset when buttons are pulled, not when power is lost
  • Improve reset logic, fix another bug

I didn't implement a reset when power is lost for a longer period of time, it just never resets when power is lost (i.e. change nothing compared to previous behavior, keep that for another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Ready to Test
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

3 participants