Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mfd): add leading zeros to track display and altitude on F-PLN page #9724

Merged

Conversation

bulenteroglu
Copy link
Contributor

Fixes #9723

Summary of Changes

  • Fixed track display formatting on MFD F-PLN page to show leading zeros for tracks between 000-099 degrees

    • Example: "45°" now displays as "045°"
  • Fixed track display formatting on MFD F-PLN page to show leading zeros for an altitude below FL99

    • Example: "FL32" now displays as "FL032"

Screenshots (if necessary)

Screenshot 2025-01-06 193844

References

image

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Create a new flight plan with:

    • Any departure/arrival airport pair
    • Cost Index: Any value
    • Cruise FL: Any value
    • Transition Altitude: Set to a low value (e.g., 3000ft or 5000ft)
  2. On the MFD F-PLN page, verify:

    • Track values below 100° are displayed with leading zeros (e.g., "045°" instead of "45°")
    • Track values 100° and above display normally (e.g., "120°")
  3. Verify altitude predictions:

    • Below FL100 should show leading zero (e.g., "FL089")
    • FL100 and above should display normally (e.g., "FL330")

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@G-DRAW
Copy link

G-DRAW commented Jan 7, 2025

Is it possible to model the diagonal line going through all of the 0's, or is that a limitation?

@bulenteroglu
Copy link
Contributor Author

Is it possible to model the diagonal line going through all of the 0's, or is that a limitation?

I have 0 clue I am afraid. Wouldn't be done in this PR anyway but I am not sure if its a limitation, or needs some sort of custom font to be done (Is there a open issue for that?)

@BravoMike99
Copy link
Contributor

We already have the slashthrough font but it might not be in use on this page (@flogross89 might know) I believe. In any case, a github issue would be the way to go 👍

@flogross89
Copy link
Contributor

We already have the slashthrough font but it might not be in use on this page (@flogross89 might know) I believe. In any case, a github issue would be the way to go 👍

Yep, we already have a font for it, it’s already used for InputFields for example. It should be as simple as replacing the Ecam font-face with the FBW-Display-EIS-A380-SlashedZero font-face, maybe you could give it a try for the F-PLN page fields.

@bulenteroglu
Copy link
Contributor Author

We already have the slashthrough font but it might not be in use on this page (@flogross89 might know) I believe. In any case, a github issue would be the way to go 👍

Yep, we already have a font for it, it’s already used for InputFields for example. It should be as simple as replacing the Ecam font-face with the FBW-Display-EIS-A380-SlashedZero font-face, maybe you could give it a try for the F-PLN page fields.

Found it - @G-DRAW
image
I'll get an issue up if not already, then also get a PR for it

@BlueberryKing BlueberryKing added the A380X Related to the A380X aircraft label Jan 9, 2025
@BravoMike99
Copy link
Contributor

Quality Assurance Tester Report

Discord Username : bruno_pt99
Object of testing : #9724
Aircraft : A380X
Tier of Testing : 1
Date : 17/01/2025

Testing Process:
Programmed a flight plan into the FMS.
Verified FL < 100 on the MFD page appear with leading zeros, FL >= 100 appear with 3 digits.
Verified TRK indications <100 appear with leading zero. Track values >= 100 appear with 3 digits.

Testing Results:
Passed

Media:
image

@BravoMike99 BravoMike99 enabled auto-merge (squash) January 17, 2025 23:59
@BravoMike99 BravoMike99 merged commit 43f8291 into flybywiresim:master Jan 18, 2025
8 checks passed
@bulenteroglu bulenteroglu deleted the MFD_trk_fl_add_padd-9723 branch January 18, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Passed QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

MFD: TRK & FL not padded with leading 0s on FPLN page
5 participants