Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom info field to ExternalResourceInfo #6115

Merged
merged 2 commits into from
Dec 18, 2024

removed unused time import

8e6a343
Select commit
Loading
Failed to load commit list.
Merged

Add custom info field to ExternalResourceInfo #6115

removed unused time import
8e6a343
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 1s

36.98% (-0.01%) compared to 87ef4a0, passed because coverage increased by 0% when compared to adjusted base (36.98%)

View this Pull Request on Codecov

36.98% (-0.01%) compared to 87ef4a0, passed because coverage increased by 0% when compared to adjusted base (36.98%)

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (87ef4a0) to head (8e6a343).

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/event/event.pb.go 15.78% 16 Missing ⚠️
...in/pkg/repositories/transformers/task_execution.go 25.00% 2 Missing and 1 partial ⚠️
...propeller/pkg/controller/nodes/task/transformer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6115      +/-   ##
==========================================
- Coverage   36.98%   36.98%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132449   132473      +24     
==========================================
+ Hits        48989    48993       +4     
- Misses      79207    79226      +19     
- Partials     4253     4254       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.