display update

Signed-off-by: Lyon Lu <lyon@union.ai>
flyteorg · Oct 17, 2024 · 2823361 · 2823361
1 parent 116ebb3
commit 2823361
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/packages/oss-console/src/components/Literals/helpers.ts b/packages/oss-console/src/components/Literals/helpers.ts
@@ -96,7 +96,7 @@ function processBinary(binary?: Core.IBinary | null) {
 
   return {
     tag: `${tag}`,
-    value: "(unsupported tag type)",
+    value: "(binary data now shown)",
   };
 }
 

diff --git a/packages/oss-console/src/components/Literals/test/helpers/genScalarBinaryTestCase.mock.ts b/packages/oss-console/src/components/Literals/test/helpers/genScalarBinaryTestCase.mock.ts
@@ -13,12 +13,9 @@ const scalarBinaryTestCases: TestCaseList<Core.IBinary> = {
     value: { value: encode(testJson), tag: 'msgpack' },
     expected: { result_var: { tag: 'msgpack', value: testJson } },
   },
-  UNSUPPORTED_TAG: {
-    value: { tag: 'tag2', value: new Uint8Array([1, 2, 3, 4]) },
-    expected: { result_var: {
-      tag: "tag2",
-      value: "(unsupported tag type)",
-    }},
+  WITH_VAL: {
+    value: { value: new Uint8Array(), tag: 'tag1' },
+    expected: { result_var: { tag: 'tag1', value: '(binary data now shown)' } },
   },
   EMPTY_VALUE: {
     value: { tag: 'msgpack' },