Fix React 19 deprecation warning when accessing child ref pre-19 way #1416
+67
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb1778b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
stefcameron
changed the title
…-19 way `child.ref` is deprecated, and generates a warning in the console in R19 because refs are now first-class props. Check the React version at runtime and if `>=19`, access it via the props; otherwise, keep accessing it as before (a property of the child React element object).
stefcameron
force-pushed
the
ref-as-prop
branch
from
e1e266a to
cb1778b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child.refis deprecated, and generates a warning in the console in R19 because refs are now first-class props.Check the React version at runtime and if
>=19, access it via the props; otherwise, keep accessing it as before (a property of the child React element object).Relates to #1343
PR Checklist
Please leave this checklist in your PR.
typeof document/window !== 'undefined'before using it in code that gets executed on load.npm run changesetlocally to add one, and follow the prompts).