Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component #2716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

UIIN-3160: Decrease the amount of re-renders of ConsortialHoldings component #2716

wants to merge 2 commits into from

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Lots of re-renders of ConsortialHoldings cause twitching when Instance details page is open.

Approach

  • Make key static, because previously it was created after each re-render of InstanceDetails component.
  • Removed uniqueId from key creation.

Refs

UIIN-3160

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   14m 45s ⏱️ -14s
1 023 tests ±0  1 021 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 030 runs  ±0  1 028 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 97a871a. ± Comparison against base commit 616fce6.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@artem-blazhko artem-blazhko requested a review from a team January 20, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-blazhko artem-blazhko artem-blazhko approved these changes

@Dmitriy-Litvinenko Dmitriy-Litvinenko Dmitriy-Litvinenko approved these changes

@mariia-aloshyna mariia-aloshyna Awaiting requested review from mariia-aloshyna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksandrHladchenko1 @Dmitriy-Litvinenko @artem-blazhko