Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statuscolumn): use extmarks cursorline hl #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

minusfive
Copy link
Contributor

@minusfive minusfive commented Jan 17, 2025

Description

Statuscolumn snack swallows the cursorline_hl_group on extmarks, causing defined cursorline highlights to break.

Related Issue(s)

TBD (searching...)

Screenshots

With appropriate GitSigns highlights defined on theme, e.g.:

-- plugin spec
{
  "lewis6991/gitsigns.nvim",
  opts = {
    culhl = true,
  },
},

--- Catppuccin
{
  GitSignsAddCul = { bg = colors.mantle, fg = colors.green },
  GitSignsChangeCul = { bg = colors.mantle, fg = colors.yellow },
  GitSignsDeleteCul = { bg = colors.mantle, fg = colors.red },
}

Before

Screenshot 2025-01-17 at 01 34 56

After

Screenshot 2025-01-17 at 01 35 06

@folke
Copy link
Owner

folke commented Jan 17, 2025

i dont think this is correct. Won't work if both a texthl and culhl are defined.
It may work in the gitsigns case, since they probably set the fg for the culhl to the same value.
The correct way would be to apply both hl groups, but I don't think that's possible with the statuscolumn syntax.

@minusfive
Copy link
Contributor Author

i dont think this is correct. Won't work if both a texthl and culhl are defined.

It may work in the gitsigns case, since they probably set the fg for the culhl to the same value.

The correct way would be to apply both hl groups, but I don't think that's possible with the statuscolumn syntax.

🤔 Will keep poking at it later.

@minusfive minusfive force-pushed the fix-statuscolumn-sign-hl branch from 25b886a to 10cd9d4 Compare January 17, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants