Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework segment_vf_collection #4966

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

benkiel
Copy link
Contributor

@benkiel benkiel commented Jan 12, 2025

Description

Relates to issue #4964

Current WIP, to see if adding the familyname bit to testable.Font is acceptible.

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@benkiel benkiel marked this pull request as draft January 12, 2025 18:29
@benkiel
Copy link
Contributor Author

benkiel commented Jan 12, 2025

@felipesanches WIP for intital review. In my test setup, somehow this is still a bit screwy, as it's telling me that there is no matching roman for a set of fonts that 100% does, have the same family name, is getting the right value to check_STAT_ital_axis so I think it might be a cache issue. Need to set this down for now, please feel free to pick up

@benkiel
Copy link
Contributor Author

benkiel commented Jan 16, 2025

@felipesanches I figured out the error: somewhere familyname is in the namespace after testable, and it is based on the file name. Changed familyname to family to match style in testable.Font and things work as expected in my test case.

@benkiel benkiel marked this pull request as ready for review January 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants