Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect flagging ecma-intrinsics: updated whitelist.js #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neha-naazneen
Copy link

The rule Validate-JavaScript-APIs(ecma-intrinsics) for JavaScript incorrectly flags couple of intrinsic methods, when they do appear to be part of the ecma specification(https://tc39.es/ecma262/). Upon scrutinizing I found that the whitelist.js used in the implementation(ecma-intrinsics.js) isn't updated. I've updated the whitelist.js.

Copy link

Thanks for the contribution! Before we can merge this, we need @neha-naazneen to sign the Salesforce Inc. Contributor License Agreement.

@neha-naazneen neha-naazneen changed the title Origin incorrect flagging ecma-intrinsics: updated whitelist.js Apr 25, 2024
Copy link

@Bartheleway Bartheleway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to documentation, Aura only supports ES5 syntax + ES6 Promises which means these functions are not recognized in such context.

A lot of purposed modifications were added in ES6 or later, thus not supported in Aura context.

Have you tested all added functions ? Aura code is compiled with Babel if I am correct which means some unrecognized code might fail the compilation.

@ghost
Copy link

ghost commented May 14, 2024

Hi @Bartheleway,
Thank you for your comment. Neha has added all the newly supported functions but testing for all of them is not done. We will review it and respond to your comment within this week.

Thanks,
Sai Anurag

@neha-naazneen
Copy link
Author

neha-naazneen commented May 31, 2024

Hello @Bartheleway, thank you for your feedback. I have compiled the code with Babel as requested and tested all the added functions to ensure they exhibit the expected behavior. All tests were successful, confirming that the functions work correctly within the Aura context.

Screenshot 2024-06-02 115359

@neha-naazneen
Copy link
Author

Hey @Bartheleway, I wanted to follow up on the pull request I submitted. I understand that maintainers are often busy, I wanted to check in to see if there's anything I can do to help move the review process along.

we are using this as a dependency, it would be greatly appreciated if these changes could be reviewed and merged at your earliest convenience.

@Bartheleway
Copy link

Hi @neha-naazneen, I'm not a maintainer of this project, just an umble user like you 😉
I hope Salesforce team will soon accept and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants