Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking passed templates by H_excess if tied with H_missing #301

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rwxayheee
Copy link
Contributor

This is a quick fix for #300. Passed current tests (in develop) and works for the triply protonated N-terminal residues. It implements the additional refinement of passed templates (previously forgiven with excess H) for minimal excess H.

My previous PR #211 caused the unexpected behavior. This is an amend to handle explicitly protonated linking atoms in the corect way.

@diogomart Would this be ok as a temporary fix? Sorry for implementing the bug ><

@rwxayheee
Copy link
Contributor Author

rwxayheee commented Jan 10, 2025

Please hold off for a short while. I would like to include two additional bug fixes before finalizing this PR. They were included in #277 but I gave up on that PR. Only need very minimal changes.

@rwxayheee
Copy link
Contributor Author

rwxayheee commented Jan 10, 2025

Added two commits that were part of #277. More detail is explained in #277.

Added example file from #300 as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant