Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select styling #5938

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix select styling #5938

merged 1 commit into from
Jan 13, 2025

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Dec 5, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9453

Description

Select components in Bootstrap 5 had no static height - it turns out that Bootstrap 5 removed the static height declaration for the .form-control class. This PR adds it in the formio global styles for backwards compatibility.

A possible alternative involved adding this style, perhaps inline, to the select component's bootstrap5 template. However, this would not work - choicesjs masks the actual input, so nothing in the template would really have a visual effect. Furthermore, we need to modify the select's parent element, and it the renderer handles adding the class in question.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist
Copy link
Member

travist commented Jan 13, 2025

+1

@lane-formio lane-formio merged commit fb495d4 into master Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants