-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and quickstart #6
Conversation
README.md
Outdated
version. Currently, this exporter has been tested with versions 19.5 and 20. | ||
|
||
The available Docker compose configuration expects these binaries to be | ||
installed in the `./hfs-bin/` directory, but you can use the directory of your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you precise the way to choose the directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a bit of complexity between the docker-compose and the config.yml
file that will be interpreted from inside the container that could be worth explaining 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that in 84eb035, hopefully this is better.
I wonder if it is for this MR or we should have a dedicated one but it could be interesting to mention in the documentation that this can also be installed as a python package. It's a cool feature that could interest the non docker crowd. What do you think ? |
I feel like it's fairly unlikely to be used like this, knowing the general recommended use case of prometheus exporters. And so any way to make the documentation a bit leaner is an added bonus. |
No description provided.