Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and quickstart #6

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

supernarthur
Copy link
Collaborator

No description provided.

README.md Outdated
version. Currently, this exporter has been tested with versions 19.5 and 20.

The available Docker compose configuration expects these binaries to be
installed in the `./hfs-bin/` directory, but you can use the directory of your
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you precise the way to choose the directory?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a bit of complexity between the docker-compose and the config.yml file that will be interpreted from inside the container that could be worth explaining 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that in 84eb035, hopefully this is better.

@bobafouette
Copy link

I wonder if it is for this MR or we should have a dedicated one but it could be interesting to mention in the documentation that this can also be installed as a python package. It's a cool feature that could interest the non docker crowd.

What do you think ?

@supernarthur
Copy link
Collaborator Author

I wonder if it is for this MR or we should have a dedicated one but it could be interesting to mention in the documentation that this can also be installed as a python package. It's a cool feature that could interest the non docker crowd.

What do you think ?

I feel like it's fairly unlikely to be used like this, knowing the general recommended use case of prometheus exporters. And so any way to make the documentation a bit leaner is an added bonus.
I guess that if there is some interest we can jump on it and make pypi packages in the CI.

@supernarthur supernarthur merged commit 02dbb39 into main Mar 18, 2024
3 checks passed
@supernarthur supernarthur deleted the 5-improve-quickstart-and-docs branch March 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve quickstart and docs (now that there is a docker image available)
3 participants