Skip to content

Commit

Permalink
wip: add missing fields to Cargo.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
cilki committed Mar 17, 2024
1 parent 816511a commit ddaa844
Show file tree
Hide file tree
Showing 6 changed files with 74 additions and 87 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# - doc: checks that the code can be documented without errors
# - hack: check combinations of feature flags
# - msrv: check that the msrv specified in the crate is correct
name: check
permissions:
contents: read
# This configuration allows maintainers of this repo to create a branch and pull request based on
Expand All @@ -19,10 +20,10 @@ on:
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
name: check
jobs:
fmt:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: stable / fmt
steps:
- uses: actions/checkout@v4
Expand All @@ -36,6 +37,7 @@ jobs:
run: cargo fmt --check
clippy:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ${{ matrix.toolchain }} / clippy
permissions:
contents: read
Expand Down Expand Up @@ -64,9 +66,10 @@ jobs:
# https://doc.rust-lang.org/beta/unstable-book/language-features/doc-cfg.html which allows an
# API be documented as only available in some specific platforms.
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: nightly / doc
steps:
- run: apt-get install -y libpango-1.0-0
- run: sudo apt-get install -y libpango-1.0-0
- uses: actions/checkout@v4
with:
submodules: true
Expand All @@ -80,6 +83,7 @@ jobs:
# cargo-hack checks combinations of feature flags to ensure that features are all additive
# which is required for feature unification
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / features
steps:
- uses: actions/checkout@v4
Expand All @@ -96,6 +100,7 @@ jobs:
msrv:
# check that we can build using the minimal rust version that is specified by this crate
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
# we use a matrix here just because env can't be used in job names
# https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
strategy:
Expand Down
31 changes: 0 additions & 31 deletions .github/workflows/publish.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: release
permissions:
pull-requests: write
contents: write

on:
push:
branches:
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# - os-check: runs the test suite on mac and windows
# - coverage: runs the test suite and collects coverage information
# See check.yml for information about how the concurrency cancellation and workflow triggering works
name: test
permissions:
contents: read
on:
Expand All @@ -15,18 +16,18 @@ on:
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
name: test
jobs:
required:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / ${{ matrix.toolchain }}
strategy:
matrix:
# run on stable and beta to ensure that tests won't break on the next version of the rust
# toolchain
toolchain: [stable, beta]
steps:
- run: apt-get install -y libpango-1.0-0
- run: sudo apt-get install -y libpango-1.0-0
- uses: actions/checkout@v4
with:
submodules: true
Expand Down Expand Up @@ -68,9 +69,10 @@ jobs:
# https://github.com/jonhoo/fantoccini/blob/fde336472b712bc7ebf5b4e772023a7ba71b2262/Cargo.toml#L47-L49.
# This action is run on ubuntu with the stable toolchain, as it is not expected to fail
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / minimal-versions
steps:
- run: apt-get install -y libpango-1.0-0
- run: sudo apt-get install -y libpango-1.0-0
- uses: actions/checkout@v4
with:
submodules: true
Expand All @@ -87,6 +89,7 @@ jobs:
os-check:
# run cargo test on mac and windows
runs-on: ${{ matrix.os }}
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ${{ matrix.os }} / stable
strategy:
fail-fast: false
Expand Down Expand Up @@ -132,9 +135,10 @@ jobs:
#
# for lots of more discussion
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'chore: release')"
name: ubuntu / stable / coverage
steps:
- run: apt-get install -y libpango-1.0-0
- run: sudo apt-get install -y libpango-1.0-0
- uses: actions/checkout@v4
with:
submodules: true
Expand Down
Loading

0 comments on commit ddaa844

Please sign in to comment.