Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #1502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.html #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 18 additions & 24 deletions client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,41 @@
<!doctype html>
<html>
<html lang="en">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application can be in different language and is set dynamically here:

selfoss/client/js/selfoss-base.js

Lines 95 to 100 in 1b2eeda

if (configuration.language !== null) {
document.documentElement.setAttribute(
'lang',
configuration.language,
);
}

<head>
<meta charset="utf-8">

<title>selfoss</title>

<!-- Will be substituted at request time. -->
<!-- Dynamic base path -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes information.

<base href="@basePath@">

<meta name="referrer" content="no-referrer" />

<!-- Mobile viewport optimized: j.mp/bplateviewport -->
<meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1" />

<!-- Add support for fullscreen Webapp on iPhone 5 -->
<meta name="viewport" content="initial-scale=1, user-scalable=yes" media="(device-height: 568px)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify why this is no longer needed?


<!-- Web application behavior -->
<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" />

<!-- Progressive Web App (PWA) Compatibility -->
<meta name="application-name" content="selfoss" />
<meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="mobile-web-app-capable" content="yes" />

<!-- icons -->
<link rel="apple-touch-icon-precomposed" href="images/icon-128x128.png" />
<link rel="icon" type="image/png" href="images/icon-32x32.png" />
<link rel="shortcut icon" type="image/x-icon" href="images/favicon.ico" />

<!-- Toolbar color from Chrome for Android -->
<meta name="theme-color" content="#191718" />

<!-- all css definitions -->
<link rel="stylesheet" href="styles/main.scss" />
<!-- Icons -->
<link rel="apple-touch-icon" href="images/icon-128x128.png" />
<link rel="icon" type="image/png" href="images/icon-32x32.png" />
<link rel="shortcut icon" href="images/favicon.ico" />

<!-- CSS Styles -->
<link rel="stylesheet" href="styles/main.css" />

<!-- web application manifest -->
<!-- Web Manifest -->
<link rel="manifest" href="selfoss.webmanifest">
</head>
<body>
<p id="js-loading-message">selfoss requires JavaScript to run, please enable it on this page.</p>
<noscript><p>selfoss requires JavaScript to run. Please enable it to continue.</p></noscript>

<p id="js-loading-message" aria-live="polite">selfoss is still loading, please wait.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause two messages will be displayed when JavaScript is disabled.


<script type="text/javascript">
<script>
document.getElementById('js-loading-message').textContent = 'selfoss is still loading, please wait.';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current state, is not this redundant?

</script>

<script src="js/index.js" onerror="document.getElementById('js-loading-message').textContent = 'Error loading selfoss JavaScript file. Please check the browser console or your web server logs.'" type="module"></script>
<script src="js/index.js" type="module" async onerror="document.getElementById('js-loading-message').textContent = 'Error loading selfoss JavaScript. Check console or server logs.'"></script>
</body>
</html>