Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the navigation bar of exhibition page #97

Closed
wants to merge 1 commit into from
Closed

Updating the navigation bar of exhibition page #97

wants to merge 1 commit into from

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Feb 28, 2019

  • Included a screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

-Updated the navigation bar of 'Exhibition Page'
-Contents on the page dont overlap now with each other
-Preview Link: https://kushthedude.github.io/2019.fossasia.org/exhibition/index.html

Screenshots if any:

Before:

screenshot 2019-02-28 at 8 29 51 pm

After:

screenshot 2019-02-28 at 8 30 06 pm


@kushthedude
Copy link
Member Author

@mariobehling ,
Sir,Please review this PR.

Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work @kushthedude

@kushthedude
Copy link
Member Author

@pranav1698 Thanks but still its not merged yet.

@pranav1698
Copy link

Wait for @mariobehling to review

@yash-kedia
Copy link
Member

u will need to provide a test link (gh-pages) to get merged.

@kushthedude
Copy link
Member Author

@yash-kedia Actually i deleted the forked regarding this issue , Any possible solution you could tell.

@kushthedude kushthedude mentioned this pull request Mar 3, 2019
3 tasks
Copy link

@imrrahul imrrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude LGTM !! But please provide the preview link so that it can be reviewed and merged fastly.

@kushthedude
Copy link
Member Author

kushthedude commented Mar 6, 2019

@imrrahul Not a issue , Here is the link https://kushthedude.github.io/summit/exhibition/index.html
What now?

@mariobehling
Copy link
Member

Please resolve conflicts.

@kushthedude
Copy link
Member Author

@mariobehling Sir,
As this Repo was accidentally deleted by me i have created a new PR with no conflicts from the Master branch you can review and check it #105

@kushthedude kushthedude closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresponsive navigation bar of exhibition page
5 participants