-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the navigation bar of exhibition page #97
Conversation
@mariobehling , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work @kushthedude
@pranav1698 Thanks but still its not merged yet. |
Wait for @mariobehling to review |
u will need to provide a test link (gh-pages) to get merged. |
@yash-kedia Actually i deleted the forked regarding this issue , Any possible solution you could tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushthedude LGTM !! But please provide the preview link so that it can be reviewed and merged fastly.
@imrrahul Not a issue , Here is the link https://kushthedude.github.io/summit/exhibition/index.html |
Please resolve conflicts. |
@mariobehling Sir, |
Changes done in this Pull Request
Description / Changes
-Updated the navigation bar of 'Exhibition Page'
-Contents on the page dont overlap now with each other
-Preview Link: https://kushthedude.github.io/2019.fossasia.org/exhibition/index.html
Screenshots if any:
Before:
After: