HRIS-379 [BE] API for My Daily Time Record > Index #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevyB
reviewed
Jul 29, 2024
Comment on lines
+22
to
+24
| it('should be defined', () => { | ||
| expect(resolver).toBeDefined(); | ||
| }); |
There was a problem hiding this comment.
this testing is useless, it only checks resolver if defined or undefined in this testcase
You can do:
- delete this test file
OR
- or create a new test case that is doing api integration testing that checks returned key valued pairs data.
Comment on lines
48
to
81
| const mappedTimesheet: TimeEntryDTO = { | ||
| user: timeEntry.user, | ||
| startTime: timeEntry.startTime ? | ||
| timeEntry.startTime.toISOString().slice(11, 19) | ||
| : null, | ||
| endTime: timeEntry.endTime ? | ||
| timeEntry.endTime.toISOString().slice(11, 19) | ||
| : null, | ||
| workedHours: timeEntry.workedHours || null, | ||
| trackedHours: timeEntry.trackedHours || null, | ||
| timeIn: timeEntry.timeIn || null, | ||
| timeOut: timeEntry.timeOut || null, | ||
| date: timeEntry.date, | ||
| late: late, | ||
| undertime: undertime, | ||
| eslChangeShift: timeEntry.eslChangeShiftRequests.length === 0 ? | ||
| null | ||
| : timeEntry.eslChangeShiftRequests, | ||
| status: workStatus, | ||
| isLeaderApproved: timeEntry.overtime?.isLeaderApproved || null, | ||
| changeShift: timeEntry.changeShiftRequest || null, | ||
| id: timeEntry.id, | ||
| userId: timeEntry.userId, | ||
| timeInId: timeEntry.timeInId || null, | ||
| timeOutId: timeEntry.timeOutId || null, | ||
| breakStartTime: timeEntry.breakStartTime, | ||
| breakEndTime: timeEntry.breakEndTime, | ||
| overtime: timeEntry.overtime || null, | ||
| changeShiftRequest: timeEntry.changeShiftRequest || null, | ||
| workInterruptions: timeEntry.workInterruptions, | ||
| eslOffsets: timeEntry.eslOffsets || null, | ||
| createdAt: timeEntry.createdAt || null, | ||
| updatedAt: timeEntry.updatedAt || null | ||
| }; |
There was a problem hiding this comment.
why do you need to map all of the fields? its not efficient
Isn't the default value null if there's no data?
you can also do this:
const formatTime = (time) => time ? time.toISOString().slice(11, 19) : null;
return {
...timeEntry,
// below fields that needs calculation like below
startTime: formatTime(timeEntry.startTime),
endTime: formatTime(timeEntry.endTime),
}
Miguel21Monacillo
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
https://framgiaph.backlog.com/view/HRIS-379
Definition of Done
Notes
Pre-condition
Db has to be running
Commands to run
npm run dev
Expected Output
It should show user's time entries and user details
Screenshots/Recordings
TimeEntriesByEmployeeId query
UserbyId query
