Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HRIS - 441] - [Bugtask] In the “Remarks” field of the Overtime Approval modal. The text overlaps the emoji icon #340

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Miguel21Monacillo
Copy link
Contributor

Issue Link

Backlog Link

Definition of Done

  • The text inputted on the remarks field for the approval of overtime no longer overlaps the emoji icon even if the texts are long.

Notes

Optional
You usually add here what the reviewer needs to be aware of.
You can provide the link for figma design if the PR is related to Markup task
You can provide the other related tasks on this PR such as Back end task if the current PR is about integration of FE and BE

Pre-condition

-[x] User role and position must be manager

Commands to run
Route links
Etc

Expected Output

It should no longer overlap the text on the emoji icon

Screenshots/Recordings

Approve Request
image

Disapprove Request
image

Copy link
Contributor

@Fontilllas Fontilllas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The text inputted on the remarks field for the approval of overtime no longer overlaps the emoji icon even if the texts are long.

Emoji.testing.Overlap.mp4

Comments: 0
Testing Time: 2min
Iterations: 0

Copy link

@jonel371234 jonel371234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

• The text inputted on the remarks field for the approval of overtime no longer overlaps the emoji icon even if the texts are long

Screen.Recording.2024-11-18.112951.mp4

Comments: 0
Testing Time: 5mins
Iterations: 0

@jessrey-asterisk jessrey-asterisk merged commit 5b62f8b into develop Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants