Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HRIS - 449] - [BUGTASK] Putting an X for clearing of entry in EVERY search bar field #345

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Miguel21Monacillo
Copy link
Contributor

Issue Link

Backlog Link

Definition of Done

  • Users can now clear the global search filter easily

Notes

Optional
You usually add here what the reviewer needs to be aware of.
You can provide the link for figma design if the PR is related to Markup task
You can provide the other related tasks on this PR such as Back end task if the current PR is about integration of FE and BE

Pre-condition

Commands to run
Route links
Etc

Expected Output

It should be easy to clear the global search filter using the clear button

Screenshots/Recordings

Clear Search Button for Global Filter

Clear.Button.for.all.search.fields.mp4

Copy link
Contributor

@jessrey-asterisk jessrey-asterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@jonel371234 jonel371234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

  • Users can now clear the global search filter easily by clicking the X button
Screen.Recording.2024-11-21.152341.mp4

Comments: 0
Test Time: 10mins
Iterations: 0

@jessrey-asterisk jessrey-asterisk merged commit 861fdc7 into develop Nov 21, 2024
4 checks passed
@Melanthonyando Melanthonyando deleted the hris-449 branch November 22, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants