Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement context input #29

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Implement context input #29

merged 2 commits into from
Nov 27, 2023

Conversation

pbrisbin
Copy link
Member

@pbrisbin pbrisbin commented Nov 21, 2023

If given and un-empty, the context string is written as the body of
the lock object on S3. When a lock is acquired or found blocking, that
context is read and included in the details show.

This can be used to supply a sort of "about me" value at acquire time,
so that we can display a sort of "held by" when waiting.

By default, this input is the workflow and run number, which means
waiting on a lock in one run of a workflow will now show you which other
run of that workflow is currently holding it.

Closes #18

If given and un-empty, the `context` string is written as the body of
the lock object on S3. When a lock is acquired or found blocking, that
context is read and included in the details show.

This can be used to supply a sort of "about me" value at acquire time,
so that we can display a sort of "held by" when waiting.

By default, this input is the workflow and run number, which means
waiting on a lock in one run of a workflow will now show you which other
run of that workflow is currently holding it.
@pbrisbin pbrisbin changed the title pb/context Implement context input Nov 21, 2023
@pbrisbin pbrisbin marked this pull request as ready for review November 21, 2023 15:45
@pbrisbin pbrisbin requested a review from a team as a code owner November 21, 2023 15:45
@pbrisbin pbrisbin requested review from joelmccracken and removed request for a team November 21, 2023 15:45
Copy link

@joelmccracken joelmccracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible/worth creating a link out of this information so person can easily jump to blocking workflow?

@pbrisbin
Copy link
Member Author

Possible, yup! Worth it, unclear. PRs welcome :)

@pbrisbin pbrisbin merged commit 9e66609 into main Nov 27, 2023
4 checks passed
@pbrisbin pbrisbin deleted the pb/context branch November 27, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store/display context when waiting on a lock
2 participants