Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] v2 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] v2 #40

wants to merge 1 commit into from

Conversation

fredbi
Copy link
Owner

@fredbi fredbi commented Sep 23, 2023

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6286394622

  • 65 of 67 (97.01%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 98.31%
Changes Missing Coverage Covered Lines Changed/Added Lines %
uri.go 58 60 96.67%
Totals Coverage Status
Change from base Build 6286240117: 1.4%
Covered Lines: 698
Relevant Lines: 710
💛 - Coveralls

@fredbi fredbi changed the title replaced interfaces by concrete type. Removed Builder type [WIP] v2 Sep 23, 2023
@fredbi fredbi force-pushed the v2 branch 2 times, most recently from 96c0690 to 6bf1d80 Compare October 27, 2023 17:05
@fredbi
v2 without pointers, without interface
bfbe4b3 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

V2 with options

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredbi @coveralls