Add visualization #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorceressyidi
commented
Dec 17, 2024
sorceressyidi
commented
- add visualization [render .pth into videos] as in https://github.com/hbb1/2d-gaussian-splatting
- add save ply as in https://github.com/graphdeco-inria/gaussian-splatting
main changes are: 1. add visualization [videos] as in https://github.com/hbb1/2d-gaussian-splatting 2. add save ply as in https://github.com/graphdeco-inria/gaussian-splatting
Wissotsky
reviewed
Dec 29, 2024
| cam.world_view_transform = torch.from_numpy(np.linalg.inv(c2w).T).float().cuda() | ||
| cam.full_proj_transform = (cam.world_view_transform.unsqueeze(0).bmm(cam.projection_matrix.cuda().unsqueeze(0))).squeeze(0) | ||
| cam.camera_center = cam.world_view_transform.inverse()[3, :3] | ||
| cam.timestamp =10.0/n_frames*i |
There was a problem hiding this comment.
Here the max timestamp value is hardcoded. This breaks other datasets which have a different scale(e.g dnerf with 0.0->1.0). I think you should be able to pass down the time_duration value from the config .yaml file
There was a problem hiding this comment.
Thank you for your review!
You’re absolutely right – I overlooked this point. I will make the necessary changes to pass the time_duration value from the config.yaml file instead of hardcoding the max timestamp.
Let me know if you have any further suggestions, and thanks again for your helpful feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.