Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is not interest in this, feel free to let me know.
I decided to do this as libtool/autoconf was giving me a lot of trouble with cross compiling and there isn't really a good way to do both native and cross compiling due to how the dependencies work.
This makes cross compiling much easier as meson supports an
exe_wrapper
command which can be set to, for example, qemu.I verified that the same files get outputted with both this and autoconf (except for the .la files which shouldn't be installed anyway, and the .a files, which can be enabled in meson with
-Ddefault_library=both
if so desired. meson by default uses the equivalent of--disable-static
):https://gist.github.com/oreo639/cd4d3c53d8bc4d90203d647debb53dbd
(confls is autoconf and mesonls is meson)
I also verified that the resulting package can be installed and works correctly (and can be used to build ibus-anthy and fcitx-anthy).
I didn't implement
update_params
/update_params0
/update_params2
since I'm not sure how you want to handle those. (fujiwarat/anthy-unicode/calctrans/Makefile.am)Let me know if I missed anything.
I didn't add meson to the autoconf dist, if that is something you want me to do, let me know. (meson dist works by pulling the files from git so it should be fine on that side)
I also added a fix for crashing when
getpwuid()
returns null when cross compiling (due toadd_val("HOME", pw->pw_dir);
trying to dereference a null ptr). I made it such that ifgetpwuid()
returns null, HOME doesn't get added to the dictionary. I'm not sure how desirable this is. diclib should still be able to fallback ongetenv()
when that is the case, however if you have other suggestions, let me know.Of course, let me know if I missed something.