Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app flickering #56

Closed
wants to merge 69 commits into from
Closed

fix: app flickering #56

wants to merge 69 commits into from

Conversation

theomathieubhvr
Copy link
Contributor

No description provided.

@theomathieubhvr
Copy link
Contributor Author

See #15

@fulls1z3
Copy link
Owner

fulls1z3 commented Aug 7, 2017

@theomathieubhvr thanks for this PR, it's one of the suggested approaches - but as far as I remember initialNavigation has some side effects. I'll test this PR on multiple projects based on this seed and then provide some feedback.

@theomathieubhvr
Copy link
Contributor Author

Ok i did not know. I'll check too on our production websites.

Thanks !

@dr1ss
Copy link

dr1ss commented Aug 16, 2017

I tryed it on one of my apps, the meta data (title, description etc..) do not get translated.

@fulls1z3 fulls1z3 force-pushed the master branch 3 times, most recently from 00c8757 to a661d29 Compare September 9, 2017 12:58
@fulls1z3 fulls1z3 closed this Sep 9, 2017
@fulls1z3 fulls1z3 deleted the fix-app-flickering branch September 9, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants