NF: Adding actor for frustum, TEST: Adding uni tests for frustum actor #963
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEST: Adding uni tests for square actor
ManishReddyR
changed the title
ManishReddyR
changed the title
Snapshots
|
|
Hi @ManishReddyR, you have some conflict that need to be fixed. I suppose you need to merge the branch v2 or rebase on branch v2. Thank you for the future update |
|
Hello @skoudoro Thank you |
Delete fury/wgsl/mesh2.wgsl
skoudoro
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Hi @ManishReddyR,
Thank you for the update. Looks good overall, see below the last comments
| colors : ndarray (N,3) or (N, 4) or tuple (3,) or tuple (4,), optional | ||
| RGB or RGBA (for opacity) R, G, B and A should be at the range [0, 1]. | ||
| scales : int or ndarray (N,3) or tuple (3,), optional | ||
| The size of the box in each dimension. If a single value is provided, |
| >>> scene = window.Scene() | ||
| >>> centers = np.random.rand(5, 3) * 10 | ||
| >>> colors = np.random.rand(5, 3) | ||
| >>> square_actor = actor.square(centers=centers, colors=colors) |
| >>> centers = np.random.rand(5, 3) * 10 | ||
| >>> colors = np.random.rand(5, 3) | ||
| >>> square_actor = actor.square(centers=centers, colors=colors) | ||
| >>> scene.add(square_actor) |
| npt.assert_array_almost_equal(mean_vertex, centers[0]) | ||
|
|
||
| assert frustum_actor.prim_count == 1 | ||
| scene.remove(frustum_actor) |
There was a problem hiding this comment.
Yes, add the snapshot test since it works now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to add actor and uni tests for frustum actor