add simple header and navigation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
skumpulainen
commented
Oct 8, 2024
skumpulainen
commented
- add simple header and navigation
- decided to use css modules
Kitsupitsu
approved these changes
Oct 14, 2024
| return ( | ||
| <NavigationMenu.Item key={i}> | ||
| <NavigationMenu.Link | ||
| data-active={location.pathname === navigationRoute.href ? true : false} |
There was a problem hiding this comment.
This could be simplified to location.pathname === navigationRoute.href
There was a problem hiding this comment.
yes, totally!
| <NavigationMenu.List className={styles["navigation-menu-list"]}> | ||
| {navigationRoutes.map((navigationRoute, i) => { | ||
| return ( | ||
| <NavigationMenu.Item key={i}> |
There was a problem hiding this comment.
Would it be possible and reasonable to use navigationRoute.name as key instead of index?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.