Remove goversioninfo

fxzxmicah · Oct 26, 2024 · a0a5648 · a0a5648
1 parent bbcdd66
commit a0a5648
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 67 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -32,12 +32,17 @@ jobs:
           NAME: clash
           BINDIR: bin
         run: |
-          make build_dep
           make -j releases
 
+      - name: Upload Artifact
+        uses: actions/upload-artifact@v4
+        if: ${{ ! startsWith(github.ref, 'refs/tags/') }}
+        with:
+          path: build/releases/*
+
       - name: Upload Release
         uses: softprops/action-gh-release@v2
-        if: startsWith(github.ref, 'refs/tags/')
+        if: ${{ startsWith(github.ref, 'refs/tags/') }}
         with:
           files: build/releases/*
           draft: false
diff --git a/Makefile b/Makefile
@@ -2,7 +2,7 @@ NAME=clash-core
 BUILDDIR=build/releases
 VERSION=$(shell git describe --tags || echo v0.0.0-test)
 BUILDTIME=$(shell date -u)
-GOBUILD=CGO_ENABLED=0 go generate && go build -trimpath -ldflags '-X "github.com/Dreamacro/clash/constant.Version=$(VERSION)" \
+GOBUILD=CGO_ENABLED=0 go build -trimpath -ldflags '-X "github.com/Dreamacro/clash/constant.Version=$(VERSION)" \
 		-X "github.com/Dreamacro/clash/constant.BuildTime=$(BUILDTIME)" \
 		-w -s -buildid='
 
@@ -25,9 +25,6 @@ WINDOWS_ARCH_LIST = \
 	windows-arm64 \
 	windows-armv7
 
-build_dep:
-	go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@latest
-
 all: linux-amd64 windows-amd64 # Most used
 
 linux-386:

diff --git a/main.go b/main.go
@@ -1,4 +1,3 @@
-//go:generate goversioninfo
 package main
 
 import (

diff --git a/resource/goversioninfo.exe.manifest b/resource/goversioninfo.exe.manifest
diff --git a/versioninfo.json b/versioninfo.json