Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added logger config #30

Closed
wants to merge 6 commits into from
Closed

feat: Added logger config #30

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1834f17
feat: Add extensive loggers
Ashutosh619-sudo Oct 3, 2024
5d390a6
comment resolved
Ashutosh619-sudo Oct 8, 2024
5ddabed
dump up version
Ashutosh619-sudo Oct 8, 2024
bf8f7ff
resolved comment
Ashutosh619-sudo Oct 8, 2024
82635f2
feat: Added logger config
Ashutosh619-sudo Oct 10, 2024
d212165
Merge branch 'master' into add-extensive-loggers
Ashutosh619-sudo Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions qbosdk/apis/api_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
"""
API Base class with util functions
"""
import sys
import logging
import logging.config
import json
from typing import List, Dict, Generator

Expand All @@ -10,6 +12,9 @@
from ..exceptions import WrongParamsError, InvalidTokenError, QuickbooksOnlineSDKError, \
NoPrivilegeError, NotFoundItemError, ExpiredTokenError, InternalServerError

logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if this is required and remove

logging.getLogger("urllib3").setLevel(logging.WARNING)
logging.getLogger("requests").setLevel(logging.WARNING)
logger = logging.getLogger(__name__)

class ApiBase:
Expand Down Expand Up @@ -254,12 +259,13 @@ def _post_request(self, data, api_url):
json=data
)

logger.debug('Payload for post request: %s', data)

if response.status_code == 200:
logger.debug('Response for post request: %s', response.text)
result = json.loads(response.text)
return result

logger.debug('Payload for post request: %s', data)
logger.info('Response for post request: %s', response.text)

if response.status_code == 400:
Expand Down Expand Up @@ -306,13 +312,13 @@ def _post_file(self, data, api_url):
data=data
)

logger.debug('Payload for post request: %s', data)

if response.status_code == 200:
logger.debug('Response for post request: %s', response.text)
result = json.loads(response.text)
return result['AttachableResponse'][0]['Attachable']


logger.debug('Payload for post request: %s', data)
logger.info('Response for post request: %s', response.text)

if response.status_code == 400:
Expand Down