This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
Added support for getting the current launcher app package #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm not sure to understand the goal of this PR. |
|
This adds support for getting the package name of the current launcher app. (e.g.: https://www.tomsguide.com/round-up/best-android-launchers) |
g123k
suggested changes
Apr 2, 2022
| @@ -139,6 +139,14 @@ class DeviceApps { | |||
| .catchError((dynamic err) => false); | |||
| } | |||
|
|
|||
| /// Get the current Launcher app's package name | |||
| static Future<String?> getCurrentLauncherApp() { | |||
There was a problem hiding this comment.
Could you rename the method to getCurrentDeviceLauncherApp?
Because I find the current name misleading
| Intent intent = new Intent("android.intent.action.MAIN"); | ||
| intent.addCategory("android.intent.category.HOME"); | ||
| String packageName = localPackageManager | ||
| .resolveActivity(intent, PackageManager.MATCH_DEFAULT_ONLY) |
There was a problem hiding this comment.
ResolveActivity may return null.
Could you handle this case please?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.