Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support refraction with BTDF #704

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature.

What is the current behavior? (You can also link to an open issue here)

BRDF is not supported in light transmission with refraction.

What is the new behavior (if this is a feature change)?

support BTDF with refraction in light transmission and KHR_materials_volume plugin.

@zhuxudong zhuxudong added enhancement New feature or request Rendering Rendering related functions labels Mar 24, 2022
@zhuxudong zhuxudong added this to the 0.7 milestone Mar 24, 2022
@zhuxudong zhuxudong self-assigned this Mar 24, 2022
@zhuxudong zhuxudong changed the base branch from main to dev/0.7 March 24, 2022 10:23
@zhuxudong zhuxudong linked an issue Mar 24, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev/0.7@5086d41). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f9c7183 differs from pull request most recent head e7ef604. Consider uploading reports for the commit e7ef604 to get more accurate results

@@            Coverage Diff             @@
##             dev/0.7     #704   +/-   ##
==========================================
  Coverage           ?   44.10%           
==========================================
  Files              ?      414           
  Lines              ?    22009           
  Branches           ?     3024           
==========================================
  Hits               ?     9707           
  Misses             ?    12302           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5086d41...e7ef604. Read the comment docs.

@GuoLei1990 GuoLei1990 changed the base branch from dev/0.7 to dev/0.8 May 6, 2022 02:49
@GuoLei1990 GuoLei1990 deleted the branch galacean:main August 4, 2022 06:48
@GuoLei1990 GuoLei1990 closed this Aug 4, 2022
@GuoLei1990 GuoLei1990 reopened this Aug 4, 2022
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.8 to dev/0.9 August 4, 2022 08:37
@GuoLei1990 GuoLei1990 changed the base branch from dev/0.9 to main August 4, 2022 08:37
@GuoLei1990 GuoLei1990 removed this from the 0.7 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBR Material interface redesign
3 participants