Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for debug mode on example iframes #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

decioferreira
Copy link

This change allows a very simple change on the example build, to allow for the examples to be compiled in debug mode.

@gampleman
Copy link
Owner

I've considered this before, but one of the reasons I'm a bit sceptical of this is that it will change the screenshots - they will now have the debug UI visible in them.

There is however an option in the screenshot producing library that allows you to hide a certain element before taking a screenshot, so perhaps we could use that? In that way the screenshots should look the same in debug mode as they do in normal operation.

@decioferreira
Copy link
Author

I take your point. In my use case, I was only using the debug mode to review the messages and state on the examples I was building, so it was not a problem that the screenshots had the debugger element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants