Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update equinix sdk #303

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Update equinix sdk #303

merged 5 commits into from
Nov 6, 2024

Conversation

schrodit
Copy link
Collaborator

@schrodit schrodit commented Mar 8, 2024 •
edited
Loading

How to categorize this PR?

/area quality
/kind enhancement
/platform equinix-metal

What this PR does / why we need it:

Updates the equinix sdk to use the newer equinix one instead of the old packet one

Fixes #265

Special notes for your reviewer:

@schrodit schrodit self-assigned this Mar 8, 2024
@schrodit schrodit requested review from jonas-zipprick and a team as code owners March 8, 2024 16:12
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) labels Mar 8, 2024
@gardener-robot
Copy link

@schrodit Thank you for your contribution.

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 8, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Mar 8, 2024
@gardener-robot gardener-robot added the needs/review Needs review label Mar 8, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 8, 2024
@gardener-robot
Copy link

@jonas-zipprick You have pull request review open invite, please check

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Sep 11, 2024
@gardener-robot
Copy link

@schrodit You need rebase this pull request with latest master branch. Please check.

@RiRa12621
Copy link
Collaborator

/needs-rebase

@gardener-robot
Copy link

@RiRa12621 Command /needs-rebase is not known.

@schrodit schrodit requested a review from RiRa12621 as a code owner November 5, 2024 18:55
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
schrodit
schrodit commented Nov 5, 2024
View reviewed changes
pkg/webhook/controlplane/ensurer_test.go
@@ -150,94 +162,6 @@ var _ = Describe("Ensurer", func() {
Expect(err).To(Not(HaveOccurred()))
checkKubeAPIServerDeployment(dep, "1.26.0", annotations)
})

It("should keep the NODE_NETWORK env variable in the kube-apiserver deployment if its value does not change", func() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the vpn-seed conatiner in the apiserver does not exist anymore

@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
RiRa12621
RiRa12621 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@RiRa12621 RiRa12621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

maybe add a test but not blocking on that.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 5, 2024
@RiRa12621 RiRa12621 merged commit 0381849 into gardener:master Nov 6, 2024
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiRa12621 RiRa12621 RiRa12621 approved these changes

@jonas-zipprick jonas-zipprick Awaiting requested review from jonas-zipprick jonas-zipprick is a code owner

Assignees

@schrodit schrodit

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility Deprecation
4 participants
@schrodit @gardener-robot @RiRa12621 @ci-shared-oss-pipeline-0