Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logos and Updated Colors #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Logos and Updated Colors #59

wants to merge 2 commits into from

Conversation

dijodaiju7
Copy link

@dijodaiju7 dijodaiju7 commented Dec 5, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

-> Added logo of bitbucket, wordpress and medium
-> Changed the colors of logo to their original color

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@garimasingh128
Copy link
Owner

  • Change base branch to develop as its already mentioned in readme
  • fill up the PR description properly as to what u have done
  • Mention the issues this PR solves
  • If it does not solves an issue, first create an issue, claim it and then create a PR otherwise your scores won't be given to you
  • content and changes looks fine but I would advice you to double check for minor errors if any.

@garimasingh128
Copy link
Owner

Also conflicting files: popup.html are present. Resolve them also.

@dijodaiju7
Copy link
Author

I've Updated edit.html

@garimasingh128
Copy link
Owner

  • Change base branch to develop as its already mentioned in readme
  • Mention the issues this PR solves
  • Resolve conflicts at
    Conflicting files
    edit.html
    popup.html

@garimasingh128
Copy link
Owner

Please do this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants