Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrex: replace BB_ENV_EXTRAWHITE with BB_ENV_PASSTHROUGH_ADDITIONS #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denix0
Copy link

@denix0 denix0 commented Feb 22, 2022

As part of OE-Core/Bitbake inclusive language variable renames.

Signed-off-by: Denys Dmytriyenko denis@denix.org

As part of OE-Core/Bitbake inclusive language variable renames.

Signed-off-by: Denys Dmytriyenko <denis@denix.org>
Copy link

@amstewart amstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endorsed!

But is there a reasonable way for the capture module to support both generations of bitbake? My org will soon be maintaining two concurrent mainlines, one on bitbake 1.38 and the other on >2.0. I'd like to be able to continue using the pyrex master ref on the old bitbake, if possible.

Maybe pyrex can prefer to use whichever whitelist variable is defined within the container-host environment? Then at least the user can fixup their host to match their bitbake version.

@denix0
Copy link
Author

denix0 commented Sep 16, 2022

Endorsed!

But is there a reasonable way for the capture module to support both generations of bitbake? My org will soon be maintaining two concurrent mainlines, one on bitbake 1.38 and the other on >2.0. I'd like to be able to continue using the pyrex master ref on the old bitbake, if possible.

Maybe pyrex can prefer to use whichever whitelist variable is defined within the container-host environment? Then at least the user can fixup their host to match their bitbake version.

FWIW, this is exactly the reason it hasn't been merged for 7 month.

My workaround - I use my fork with the patch applied for Kirkstone+ projects, and use the original for Dunfell- projects otherwise.

I hope @JoshuaWatt is able to figure out how to handle this :)

@JoshuaWatt
Copy link
Collaborator

Endorsed!
But is there a reasonable way for the capture module to support both generations of bitbake? My org will soon be maintaining two concurrent mainlines, one on bitbake 1.38 and the other on >2.0. I'd like to be able to continue using the pyrex master ref on the old bitbake, if possible.
Maybe pyrex can prefer to use whichever whitelist variable is defined within the container-host environment? Then at least the user can fixup their host to match their bitbake version.

FWIW, this is exactly the reason it hasn't been merged for 7 month.

My workaround - I use my fork with the patch applied for Kirkstone+ projects, and use the original for Dunfell- projects otherwise.

I hope @JoshuaWatt is able to figure out how to handle this :)

Yep, it's on the TODO list; I was hoping we could figure out a way to do it without make separate releases, but I'm just not sure if that's going to work. If anyone has any ideas to make it work, let me know.

@JoshuaWatt
Copy link
Collaborator

I believe this is resolved by #81 Please confirm and close if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants