-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): minor refactor of console functions #14956
Conversation
see the issue for details on the functions changed fixes issue #14834
Could someone review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure of the original reason for this PR -- so tagging in @sidharthachatterjee to provide some context. Thanks!
remove file to satisify code review request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!, this is great thanks!
Holy buckets, @leonlafa — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
@wardpeet My next task is to go through and change all the console function instances and refactor for reporter.log functions as suggested by @sidharthachatterjee What's the best practice? Should I raise a new issue myself or should I let one of the members raise it and then I'll start work on it? |
This reverts commit 7775b3e.
Description
To discourage the use of console.log in our plugins so everything that is called directly on console functions ends up being a regular log.
Related Issues
fixes issue #14834