-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use stable rust #37
use stable rust #37
Conversation
alexander-buerger-met-no
commented
Aug 13, 2024
- use hidefix 0.11.1
- use divan for benches
- some functions are "pub" to make them available in benches
- keep hexyl at 0.9 as 0.14 does not compile
@magnusuMET I am not sure how to avoid the |
I don't see an easy way since type inference through the result type is tricky. You might make |
The memory leak is from env RUSTFLAGS="-Z sanitizer=address" ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-14 cargo test --target x86_64-unknown-linux-gnu -p dars --test coads -- --nocapture coads_subset |
Interesting, probably of interest to hdf5 as well. |
We run the address sanitizer in the |
Maybe it is caused by dars, some of the attribute stuff is using hdf
directly.
ons. 14. aug. 2024, 11:01 skrev Magnus Ulimoen ***@***.***>:
… We run the address sanitizer in the hdf5 crate which does not reveal any
leaks. The backtrace isn't very helpful either and I am not sure how to
track down the leak
—
Reply to this email directly, view it on GitHub
<#37 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN3654MHJF6CUFWNKWKVLZRMMFPAVCNFSM6AAAAABMONX3IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGIZDQMZTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
- skip doc comment suggestions
Reading |
Those files were found in the hyrax test suite. They also appear to be less unused than the path suggests. |
I removed that troublesome file. If someone wants to hunt down that leak we can always add it back in. Clippy was also really strict for package metadata, if we are planning on releasing the crates on crates.io we could blacklist the warnings again. |
Great! Thanks a lot both! |