Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stable rust #37

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Conversation

alexander-buerger-met-no
Copy link
Contributor

  • use hidefix 0.11.1
  • use divan for benches

- some functions are "pub" to make them available in benches
- keep hexyl at 0.9 as 0.14 does not compile
@alexander-buerger-met-no
Copy link
Contributor Author

@magnusuMET I am not sure how to avoid the make_extents function in dars/src/lib.rs. This function is copied from the hidefix tests for Extents.

@magnusuMET
Copy link
Collaborator

I don't see an easy way since type inference through the result type is tricky. You might make stream_xdr take an Extents instead, pushing the trouble of making Extents upwards in the stack

@magnusuMET
Copy link
Collaborator

The memory leak is from H5MM_xstrdup, found by running

env RUSTFLAGS="-Z sanitizer=address" ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-14 cargo test --target x86_64-unknown-linux-gnu -p dars --test coads -- --nocapture coads_subset

@gauteh
Copy link
Owner

gauteh commented Aug 14, 2024

The memory leak is from H5MM_xstrdup, found by running

env RUSTFLAGS="-Z sanitizer=address" ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-14 cargo test --target x86_64-unknown-linux-gnu -p dars --test coads -- --nocapture coads_subset

Interesting, probably of interest to hdf5 as well.

@magnusuMET
Copy link
Collaborator

We run the address sanitizer in the hdf5 crate which does not reveal any leaks. The backtrace isn't very helpful either and I am not sure how to track down the leak

@gauteh
Copy link
Owner

gauteh commented Aug 14, 2024 via email

@magnusuMET
Copy link
Collaborator

magnusuMET commented Aug 14, 2024

Reading data/dmrpp/unused/ntypes.h5 gives the memory leak, in specific the compound_type_4 dataset

@gauteh
Copy link
Owner

gauteh commented Aug 14, 2024

Reading data/dmrpp/unused/ntypes.h5 gives the memory leak, in specific the compound_type_4 dataset

Those files were found in the hyrax test suite. They also appear to be less unused than the path suggests.

@magnusuMET
Copy link
Collaborator

I removed that troublesome file. If someone wants to hunt down that leak we can always add it back in.

Clippy was also really strict for package metadata, if we are planning on releasing the crates on crates.io we could blacklist the warnings again.

@gauteh
Copy link
Owner

gauteh commented Aug 15, 2024

Great! Thanks a lot both!

@gauteh gauteh merged commit d30fc30 into gauteh:master Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants