Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document more obsolete syntax #1618

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Document more obsolete syntax #1618

merged 2 commits into from
Jan 19, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 18, 2025

Fixes #1601

Screen Shot 2025-01-18 at 13 25 26

@Rangi42 Rangi42 added docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM labels Jan 18, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 18, 2025
@Rangi42 Rangi42 requested a review from ISSOtm January 18, 2025 03:46
ISSOtm
ISSOtm previously requested changes Jan 18, 2025
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are clearly bugs, so I think they should be documented separately, if at all.

I don't want them to feel intended, because then that's material for our decisions to be questioned; but I can understand wanting to point it out as help for people to upgrade. So let's create a "BUGS" section, IMO.

@Rangi42 Rangi42 requested a review from ISSOtm January 18, 2025 18:26
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

@Rangi42 Rangi42 merged commit 147a5c9 into gbdev:master Jan 19, 2025
25 checks passed
@Rangi42 Rangi42 deleted the more-old branch January 19, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document "Spaces between label and colons" in rgbasm-old.5
2 participants