Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running external tests against installed rgbds #1621

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Allow running external tests against installed rgbds #1621

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb354f7
Added option to only run external tests, added option to use system-i…
robbi-blechdose Jan 21, 2025
d9f60e6
Reverted changes to man file
robbi-blechdose Jan 21, 2025
fb04e77
Added safeguards
robbi-blechdose Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 34 additions & 12 deletions test/run-tests.sh
View file
Open in desktop
robbi-blechdose marked this conversation as resolved.
Show resolved Hide resolved
robbi-blechdose marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ usage() {

# Parse options in pure Bash because macOS `getopt` is stuck
# in what util-linux `getopt` calls `GETOPT_COMPATIBLE` mode
installedrgbds=false
nonfree=true
internal=true
external=true
FETCH_TEST_DEPS="fetch-test-deps.sh"
while [[ $# -gt 0 ]]; do
Expand All @@ -29,6 +31,12 @@ while [[ $# -gt 0 ]]; do
--only-internal)
external=false
;;
--only-external)
internal=false
;;
--installed-rgbds)
Rangi42 marked this conversation as resolved.
Show resolved Hide resolved
installedrgbds=true
;;
--)
break
;;
Expand All @@ -40,19 +48,28 @@ while [[ $# -gt 0 ]]; do
shift
done

# Refuse to run if RGBDS isn't present
if [[ ! ( -x ../rgbasm && -x ../rgblink && -x ../rgbfix && -x ../rgbgfx ) ]]; then
echo "Please build RGBDS before running the tests"
false
if "$installedrgbds"; then
# Refuse to run if RGBDS isn't installed
if ! (command -v rgbasm 2>&1 >/dev/null && command -v rgblink 2>&1 >/dev/null && command -v rgbfix 2>&1 >/dev/null && command -v rgbgfx 2>&1 >/dev/null); then
echo "Please install RGBDS before running the tests"
false
fi
else
# Refuse to run if RGBDS isn't present
robbi-blechdose marked this conversation as resolved.
Show resolved Hide resolved
if [[ ! ( -x ../rgbasm && -x ../rgblink && -x ../rgbfix && -x ../rgbgfx ) ]]; then
echo "Please build RGBDS before running the tests"
false
fi
fi

# Tests included with the repository

for dir in asm link fix gfx; do
pushd $dir
./test.sh
popd
done
if "$internal"; then
for dir in asm link fix gfx; do
pushd $dir
./test.sh
popd
done
fi

if ! "$external"; then
exit
Expand All @@ -68,8 +85,13 @@ test_downstream() { # owner repo make-target build-file build-hash
echo >&2 'Please run `'"$FETCH_TEST_DEPS"'` before running the test suite'
return 1
fi
make clean RGBDS=../../
make -j4 "$3" RGBDS=../../
if "$installedrgbds"; then
make clean
make -j4 "$3"
else
make clean RGBDS=../../
make -j4 "$3" RGBDS=../../
fi
hash="$(sha1sum -b "$4" | head -c 40)"
if [ "$hash" != "$5" ]; then
echo >&2 'SHA-1 hash of '"$4"' did not match: '"$hash"
Expand Down
Loading