Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pressure sensibility to stroke width computation #122

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added pressure sensibility to stroke width computation #122

wants to merge 7 commits into from

Conversation

sommoMicc
Copy link

I added pressure sensibility to stroke width computation. So devices like Samsung Galaxy Note with an active pen (with pressure level detection) can draw a more realistic signature.

I've also updated build tools and gradle version.

gcacace
gcacace reviewed Sep 1, 2018
View reviewed changes
Copy link
Owner

@gcacace gcacace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts in putting together this contribution. A few comments.

signature-pad/build.gradle Outdated Show resolved Hide resolved
signature-pad/src/main/java/com/github/gcacace/signaturepad/views/SignaturePad.java Outdated Show resolved Hide resolved
signature-pad/src/main/java/com/github/gcacace/signaturepad/views/SignaturePad.java Outdated Show resolved Hide resolved
signature-pad/src/main/java/com/github/gcacace/signaturepad/views/SignaturePad.java Outdated Show resolved Hide resolved
signature-pad/src/main/java/com/github/gcacace/signaturepad/views/SignaturePad.java Show resolved Hide resolved
@sommoMicc
Copy link
Author

sommoMicc commented Sep 1, 2018 •
edited
Loading

Hi
I've fixed (in my fork). Sould I make another pull request?

@sommoMicc sommoMicc closed this Sep 1, 2018
@sommoMicc sommoMicc reopened this Sep 1, 2018
@sommoMicc
Copy link
Author

I had to increment min-sdk from 9 to 14 in SignaturePad-Example because of the requirements of new google appcompat library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcacace gcacace gcacace left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sommoMicc @gcacace