Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix pyright type checks on benchmark directory #935

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: Fix pyright type checks on benchmark directory #935

wants to merge 12 commits into from

Conversation

qh681248
Copy link
Contributor

@qh681248 qh681248 commented Jan 21, 2025 •
edited
Loading

#912

PR Type

  • Bugfix

Description

Static type check fixes

How Has This Been Tested?

Existing tests pass as expected.

Pyright passes on benchmark directory with 0 warnings, 0 errors and 0 informations.

Does this PR introduce a breaking change?

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@qh681248 qh681248 linked an issue Jan 21, 2025 that may be closed by this pull request
Fix static type checker complaints for benchmarking #912
Open
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit f4b042c - Merge 62cfb83 into 8308711

No significant changes to performance.

@qh681248 qh681248 marked this pull request as ready for review January 21, 2025 15:47
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 2808b74 - Merge 1c5a736 into 8308711

No significant changes to performance.

@qh681248 qh681248 changed the base branch from main to feature/add-kernel-thinning-to-benchmarking January 21, 2025 16:12
@qh681248 qh681248 changed the base branch from feature/add-kernel-thinning-to-benchmarking to main January 21, 2025 16:12
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 48bc4a9 - Merge 8c17210 into 8308711

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 6def9d9 - Merge 98369c8 into 8308711

No significant changes to performance.

@rg936672
Copy link
Contributor

Blocked by #927 as this contains the commits from that PR as well. (Either wait for that PR to be merged, or rebase the commits unique to this PR onto main.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix static type checker complaints for benchmarking
2 participants
@qh681248 @rg936672