Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-321: Add ChainedIterator varargs constructor and IterableMerge binary operator #328

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Gh-321: Add ChainedIterator varargs constructor and IterableMerge binary operator #328

wants to merge 4 commits into from

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Jan 15, 2025 •
edited by github-actions bot
Loading

  • Adds a varargs constructor to ChainedIterator.java
  • Add a new IterableMerge binary operator that concats iterables (similar to the IterableConcat function)

Related issue

@cn337131 cn337131 marked this pull request as ready for review January 15, 2025 12:42
GCHQDeveloper314
GCHQDeveloper314 reviewed Jan 15, 2025
View reviewed changes
core/src/main/java/uk/gov/gchq/koryphe/iterable/ChainedIterator.java Outdated
@@ -16,9 +16,12 @@

package uk.gov.gchq.koryphe.iterable;

import org.apache.commons.lang3.ArrayUtils;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend against this unless there's no other easy way to do this with external libraries.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cn337131 cn337131 added the enhancement Improvement to existing functionality/feature label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p29876 p29876 p29876 approved these changes

@tb06904 tb06904 tb06904 approved these changes

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChainedIterator doesn't have a varargs constructor
4 participants
@cn337131 @GCHQDeveloper314 @tb06904 @p29876