Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inference routines #116

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Update inference routines #116

merged 6 commits into from
Oct 1, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Oct 1, 2024

Warning

Breaking change: bumping version to v0.6.0

  • Remove single-sequence forward!, viterbi! and forward_backward! from the public API, rename them with a leading underscore.
  • Modify _forward!, _viterbi! and _forward_backward! by passing them k instead of t1, t2 so that they can update logL in place. This is breaking because the API of these subfunctions is documented. This change will be useful to tackle Integration with SSMProblems Ecosystem #104.
  • Remove last bit of multithreading in fit! and reactivate the no-allocation tests.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (882f2f7) to head (865947d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   95.17%   95.20%   +0.02%     
==========================================
  Files          17       17              
  Lines         497      500       +3     
==========================================
+ Hits          473      476       +3     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Update logL in the inference routines Update inference routines Oct 1, 2024
@gdalle gdalle merged commit 38eb996 into main Oct 1, 2024
8 checks passed
@gdalle gdalle deleted the gd/predict branch October 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant