refactor(ethexe): service based architecture #4456
Conversation
ark0f
changed the title
| .gossipsub | ||
| .publish(gpu_commitments_topic(), data) | ||
| { | ||
| log::debug!("gossipsub publishing failed: {e}") |
There was a problem hiding this comment.
That must be log::error
Last time when semi-redundant delay was removed from the Node::start_service method here the test was failing and the reason for that was that node's networking service was trying to publish a message in a network with 2 nodes (the third one because of no delay didn't have enough time to start it's networking service). Having error log could make it really easy to locate an error
| ethexe-validator.workspace = true | ||
| ethexe-sequencer.workspace = true |
ethexe/observer/src/lib.rs
Outdated
| type BlobDownloadFuture = BoxFuture<'static, Result<(CodeId, Vec<u8>)>>; | ||
|
|
||
| impl ObserverService { | ||
| pub async fn cloned(&self) -> Result<Self> { |
There was a problem hiding this comment.
can be just clone - that seems closer to the naming convetion, as cloned and copied is used for creating an owned version of some reference to the type
breathx
changed the title
| @@ -34,3 +34,10 @@ pub const fn u64_into_uint48_be_bytes_lossy(val: u64) -> [u8; 6] { | |||
|
|
|||
| [b1, b2, b3, b4, b5, b6] | |||
| } | |||
|
|
|||
| pub fn option_call<S>( | |||
There was a problem hiding this comment.
mb make it as trait OptionExt { fn option_call(...) -> ... {} }
option_call(&mut sequencer, |s| s.on_new_head(hash))?;
vs
sequencer.as_mut().option_call(|s| s.on_new_head(hash))
| }; | ||
| Some(event) = observer.next() => { | ||
| match event? { | ||
| ObserverEvent::Block(block) => { |
There was a problem hiding this comment.
match in order of
pub enum ObserverEvent {
Blob { code_id: CodeId, code: Vec<u8> },
Block(BlockData),
}| sequencer.as_mut(), | ||
| network_sender.as_mut(), | ||
| ); | ||
| SequencerEvent::CollectionRoundEnded { block_hash: _} => { |
There was a problem hiding this comment.
cargo fmt does not work for macros
| SequencerEvent::CollectionRoundEnded { block_hash: _} => { | |
| SequencerEvent::CollectionRoundEnded { block_hash: _ } => { |
There was a problem hiding this comment.
| self.swarm.behaviour().peer_score.handle() | ||
| } | ||
|
|
||
| pub fn publish_message(&mut self, data: Vec<u8>) { |
There was a problem hiding this comment.
mb intoduce methods with impl Encode and Vec<u8>?
| pub fn publish_message(&mut self, data: Vec<u8>) { | |
| pub fn publish_message(&mut self, data: impl Encode) { |
pub fn publish_message(&mut self, data: Vec<u8>) {}
pub fn publish_network_message(&mut self, message: impl Encode) {}
No description provided.