-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom delay command #13
base: master
Are you sure you want to change the base?
Conversation
Looks pretty good! Have you tested to be sure it runs them in the right order then? |
It worked in practice in my specific circumstance and the reduce operation should chain them correctly in general, but I didn't specifically validate the ordering. I could potentially write some unit tests for it, but I'd have to familiarize myself with the VSCode tooling first (I've not written code for an extension before). To be clear, I didn't try to figure out why the |
is this going in? can't wait to have it! i have a few issues with commands running to fast, and i think a delay option will sort it out. |
@geddski Was there anything more you needed from me or other concerns before merging? I've been using my own custom build, but it might help some other people (and be more convenient for me) if it were published. |
@geddski Bump. |
Installed this and it fixed my issues without even needing to insert a delay, so it seems to be fixing some other issues as well - the macro below did not work with the main
|
bump, |
bump |
bump |
This solved a specific problem I was having, and since there was discussion in #9 about delays, I figured this might be generally useful.
Specifically, this adds
$delay
as a command (taking one argument, the delay length in milliseconds), e.g.I also fixed #5, incidentally solved the same problem as in PR #11, and removed the dependency on
promise-series
(I was having a harder time following the code with it in there and it didn't seem necessary).