fix: remove extra warning on unset deprecated option #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Sep 4, 2024
test/option.js
Outdated
| @@ -155,6 +166,18 @@ describe('option', () => { | |||
| const parser = option({isDeprecated: true}); | |||
| assert.doesNotThrow(() => parser({}, LAZY_CONFIG), MissingOptionError); | |||
| }); | |||
|
|
|||
| it('should not log warning on deprecated option', () => { | |||
There was a problem hiding this comment.
"...on deprecated option with default value"
There was a problem hiding this comment.
It does not warn on deprecated options with default values already.
It does, however, on deprecated option without one.
If option is removed, it doesn't need the default value, and developer might not provide it, assuming, {isDeprecated: true} will not log any warnings. Currently, his assumptions are falsy.
There was a problem hiding this comment.
Renamed test title to "... without any value"
KuznetsovRoman
force-pushed
the
TESTPLANE-226.warn_deprecated
branch
from
448b9a8 to
aae31be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.