-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sample annotation functionality from geo-import
process
#1334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a minor change, not a bugfix, so 2.7.2 -> 2.8.2.
40852ee
to
9402d7e
Compare
geo-import
process
ced98c4
to
8f6240d
Compare
@@ -418,53 +344,3 @@ def test_geo_ena(self): | |||
sample = sra.entity | |||
|
|||
self.assertEqual(sample.annotations.count(), 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests will fail because there are no annotations present on the sample. The line needs to be removed and then sample = sra.entity
is also no longer needed.
@@ -327,47 +294,6 @@ def test_geo_chipseq(self): | |||
|
|||
self.assertEqual(sample.annotations.count(), 11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits.
from ``geo-import`` process
3359a25
to
aa2ad55
Compare
in
geo-import
processREID-2336
before non-breaking changes.
it might be sufficient to modify the existing CHANGELOG entry from previous
commit(s).
that break the api/interface). Examples: renaming the input/output, adding
mandatory input, removing input/output...
backwards-compatible manner. Examples: add output field, add non-mandatory
input parameter, use a different tool that produces same results...
the api/interface. Examples: typo fix, change/add warning messages...