Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sample annotation functionality from geo-import process #1334

Merged
merged 1 commit into from
May 3, 2024

Conversation

marcellevstek
Copy link
Contributor

in geo-import process

REID-2336

  • Update CHANGELOG.rst for each commit separately:
    • Pay attention to write entries under the "Unreleased" section.
    • Mark all breaking changes as "BACKWARD INCOMPATIBLE:" and put them
      before non-breaking changes.
    • If a commit modifies a feature listed under "Unreleased" section,
      it might be sufficient to modify the existing CHANGELOG entry from previous
      commit(s).
  • Bump the process version:
    • MAJOR version (first number): Backward incompatible changes (changes
      that break the api/interface). Examples: renaming the input/output, adding
      mandatory input, removing input/output...
    • MINOR version (middle number): add functionality or changes in a
      backwards-compatible manner. Examples: add output field, add non-mandatory
      input parameter, use a different tool that produces same results...
    • PATCH version (last number): changes/bug fixes that do not affect
      the api/interface. Examples: typo fix, change/add warning messages...
  • All inputs are used in process.
  • All output fields have a value assigned to them.

@romunov romunov requested a review from AnzeLovse April 22, 2024 12:37
Copy link
Contributor

@romunov romunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a minor change, not a bugfix, so 2.7.2 -> 2.8.2.

@marcellevstek marcellevstek changed the title Remove inconsistently annotated fields from annotation of samples Remove sample annotation functionality from geo-import process Apr 25, 2024
@marcellevstek marcellevstek force-pushed the change/geo-import branch 2 times, most recently from ced98c4 to 8f6240d Compare April 25, 2024 09:32
@@ -418,53 +344,3 @@ def test_geo_ena(self):
sample = sra.entity

self.assertEqual(sample.annotations.count(), 7)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests will fail because there are no annotations present on the sample. The line needs to be removed and then sample = sra.entity is also no longer needed.

@@ -327,47 +294,6 @@ def test_geo_chipseq(self):

self.assertEqual(sample.annotations.count(), 11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

Copy link
Member

@jkokosar jkokosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

from ``geo-import`` process
@jkokosar jkokosar merged commit aa2ad55 into genialis:master May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants