-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pca-beta
process
#1336
Add pca-beta
process
#1336
Conversation
a52876e
to
602796e
Compare
e191651
to
43eb787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkokosar please see my review and give feedback on my thoughts on handling the species and source fields internally.
@romunov @marcellevstek the |
9e77cf2
to
95d4750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Squash and rebase, please.
c6b8ae9
to
8142a4e
Compare
REID-2321
Checklist
before non-breaking changes.
it might be sufficient to modify the existing CHANGELOG entry from previous
commit(s).
that break the api/interface). Examples: renaming the input/output, adding
mandatory input, removing input/output...
backwards-compatible manner. Examples: add output field, add non-mandatory
input parameter, use a different tool that produces same results...
the api/interface. Examples: typo fix, change/add warning messages...