Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pca-beta process #1336

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Add pca-beta process #1336

merged 1 commit into from
Jul 6, 2024

Conversation

marcellevstek
Copy link
Contributor

@marcellevstek marcellevstek commented May 13, 2024

REID-2321

Checklist

  • Update CHANGELOG.rst for each commit separately:
    • Pay attention to write entries under the "Unreleased" section.
    • Mark all breaking changes as "BACKWARD INCOMPATIBLE:" and put them
      before non-breaking changes.
    • If a commit modifies a feature listed under "Unreleased" section,
      it might be sufficient to modify the existing CHANGELOG entry from previous
      commit(s).
  • Bump the process version:
    • MAJOR version (first number): Backward incompatible changes (changes
      that break the api/interface). Examples: renaming the input/output, adding
      mandatory input, removing input/output...
    • MINOR version (middle number): add functionality or changes in a
      backwards-compatible manner. Examples: add output field, add non-mandatory
      input parameter, use a different tool that produces same results...
    • PATCH version (last number): changes/bug fixes that do not affect
      the api/interface. Examples: typo fix, change/add warning messages...
  • All inputs are used in process.
  • All output fields have a value assigned to them.

@marcellevstek marcellevstek force-pushed the change/pca branch 5 times, most recently from a52876e to 602796e Compare May 13, 2024 14:25
@marcellevstek marcellevstek changed the title Add pca-beta process [WIP] Add pca-beta process May 14, 2024
resolwe_bio/tools/pca.py Outdated Show resolved Hide resolved
@marcellevstek marcellevstek force-pushed the change/pca branch 3 times, most recently from e191651 to 43eb787 Compare May 14, 2024 09:19
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
@marcellevstek marcellevstek changed the title [WIP] Add pca-beta process Add pca-beta process May 14, 2024
Copy link
Contributor

@romunov romunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkokosar please see my review and give feedback on my thoughts on handling the species and source fields internally.

resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Show resolved Hide resolved
resolwe_bio/processes/clustering/pca.py Outdated Show resolved Hide resolved
@jkokosar
Copy link
Member

@romunov @marcellevstek the species and source inputs in the original process relate and inform the genes input, which is usually provided by the FE module (based on the genes basket state). Even though appropriate controls are implemented elsewhere, It must not be assumed that the source/species of input genes will always be the same as those of expression objects on the process inputs. It is thus not ok to remove the process inputs and related checks within the process.

Copy link
Contributor

@romunov romunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Squash and rebase, please.

@marcellevstek marcellevstek force-pushed the change/pca branch 13 times, most recently from c6b8ae9 to 8142a4e Compare July 5, 2024 09:09
@jkokosar jkokosar merged commit 7414753 into genialis:master Jul 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants