Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous integration #25

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add continuous integration #25

merged 3 commits into from
Nov 5, 2024

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Oct 28, 2024

Having a basic Continuous Integration (CI) pipeline, that runs at least on pull requests, would go a long way towards ensuring we are not accidentally breaking important functionality when developing new features.

This PR adds a very basic CI pipeline based on GitHub actions. It simply runs the pipeline on a really small set of data; two copies of the medium size dataset already available in the assets folder.

@samuell samuell linked an issue Oct 28, 2024 that may be closed by this pull request
@samuell samuell force-pushed the 23-add-ci branch 3 times, most recently from b635ab0 to 15669d6 Compare November 4, 2024 10:51
@samuell samuell force-pushed the 23-add-ci branch 3 times, most recently from fcc6e22 to 39f0bad Compare November 5, 2024 10:09
@samuell samuell self-assigned this Nov 5, 2024
@samuell samuell marked this pull request as ready for review November 5, 2024 10:20
@samuell samuell requested a review from a team as a code owner November 5, 2024 10:21
Adapted from JASEN, keeping the relevant stuff and adapting a bit to
this pipeline.
@bokelund
Copy link
Contributor

bokelund commented Nov 5, 2024

Looks good!

@bokelund bokelund closed this Nov 5, 2024
@bokelund bokelund reopened this Nov 5, 2024
Copy link
Contributor

@bokelund bokelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samuell samuell merged commit eddb78d into main Nov 5, 2024
2 checks passed
@samuell samuell deleted the 23-add-ci branch November 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add continuous integration
2 participants